Fix plot for EnsembleSummary #683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ai-maintainer[bot]](https://avatars.githubusercontent.com/in/339956?s=60&v=4){kind=small}
There was a problem hiding this comment.
AI-Maintainer Review for PR - Fix plot for EnsembleSummary
Title and Description 👍
The title and description of the pull request are clear and concise. They effectively communicate the purpose of the changes, which is to replace the usage of `idxs` with `trajectories` in the `plot` function call for `EnsembleSummary`.
Scope of Changes 👍
The changes in this pull request are narrowly focused. The author is specifically addressing the issue related to the plot for `EnsembleSummary`. There are no indications that the author is trying to resolve multiple issues simultaneously.
Testing 👎
The description does not mention how the author tested the changes. It would be helpful for the author to include information about the testing process in the description to provide transparency and ensure that the changes have been adequately tested.
Suggested Changes
Please include details about how you tested these changes. This could be unit tests you added, manual testing you did, or even just a description of the types of scenarios you considered when making these changes.
Reviewed with AI Maintainer
|
I am not sure. I thought it would plot the statistics of the third component of the Problem, not the third trajectory |
Yeah, it plots the statistics of the third component of the problem, to plot the "pure" trajectory, we need to set |
|
Yes indeed, this is supposed to be the 3rd index of each solution, not the 3rd trajectory's solution over all variables. It seems that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
plot(summ; idxs=3), we should useplot(summ; trajectories=3)